I like the Lore Bard a lot more. One, he feels more Bard-y to me from a fluff perspective (so, whatevs, ymmv) but I like the role of the Lore Bard as a skill monkey, party face, and buff master. The Valor Bard isn't good enough at combat for me to want to trade in all the Lore goodies, especially Magical Secrets. The College of Swords from XGE would be my pick if you wanted a fighty Bard, although I like Lore better than either.