Sorry but this sounds just like bad optimization. Going single weapon is just bad. On level 19 it might be ok if you pick that, but before its not a good choice. There are 18 levels before that.
Optimal on level 19/20 Rogue is Green-Flame Blade sneak attack with Combat Prowess, a 20 Dexterity and a Rapier. Single target damage is a flat 61 without advantage or 63 with advantage. That doesn't count any damage to the second target with 5 feet, doesn't use a Bonus action and it is the same DPR whether AC is 8 or 30. I would like to see the dual wielding build that beats that number. Heck, I would like to see the Dual Wielding build that beats Truestrike with an 8 casting stat at level 19 or 20 (52 damage, 54 with advantage).
Going single weapon is not bad, especially at high level. To start with Rogues have great Bonus actions, so the Dual Wielder Feat is not great on them, at any level. Nick is a good way to shore up Sneak attack opportunities at lower levels, but it is low damage, really low damage if you are talking about tier 4.
Additionally Nick really screws with critical hits against bosses. Yes Nick is a 2nd chance to hand a sneak attack, but if you hit with your Vex weapon that means the vast majority of the time you will use sneak attack on that hit. Nick is taking away the opportunity for Advantage (and the increased critical chance) the following round. Now you could always forgo using nick if you hit, but the you are resigning yourself to a lower damage weapon and consideing the Cantrip boost, substantially lower damage overall. IF you miss with your main weapon you don't get advantage from Vex when you use your nick weapon anyway.
From an optimization point of view Green Flame Blade and Truestrike blow away this in terms of damage at this level. You are using a higher damage weapon, you are getting the full benefit from Vex and you are adding 3d6 or 3d8 to your sneak attack and even more if you are damaging a 2nd guy too. With Dual Wielding even after getting the Feat and giving up your bonus action you only are adding 2d4 ranged or 2d6 melee.
Using 2 light weapons is situationally better (like if for some reason you do not qualify for sneak attack), but if those situations come up frequently you can opt into a different style when that happens. A PC who uses a single weapon most of the time can still use a Light weapon approach when warranted/needed.
The problem is how your groups play always sounds really unique and like your groups dont use math or optimization. ESPECIALLY not going for precision and trying to "use a casting stat for attacking" all the time.
Many have told me that playing regularly to 20th level is unique. Some have said "no one does that". Well we do that often.
So yes I think the groups I play to high level with are outliers, but I think that is primarily because most players rarely if ever play at that level.
Finally, Green Flame Blade (and Booming Blade) do not use a casting stat for attacking, they use Dexterity or Strength. That said, if you have Combat Prowess precision doesn't matter. Even with a 3 on your casting stat, Truestrike is going to give you more damage than attacking without a Cantrip. With a -3 on your attack roll you still hit every time with Combat Prowess and you still crit on a 20 and the extra 10.5 damage (extra 21 on a crit) is still worth more than you would get from your dex bonus even with the -3 to damage factored in there .... and no one actually has a 3, most of the time it is at least a 12.
Also why should a single weapon be better for critical hits?
Because of Vex. If you are playing with Vex-Nick you hit with the Vex weapon (short Sword or Hand Crossbow) and you use Sneak Attack, then you don't have Sneak Attack when you attack with the Nick weapon with advantage. Next turn when you attack with the Vex weapon you don't have advantage because you used it with the Nick Weapon. You would need to hit and purposely withold doing Sneak Attack damage on your first hit to enable the increased crit chance for the 2nd weapon
You can get around this by using 2 Short Swords and burning your Bonus action every turn, but that is rarely a good option tactically.
You can also get around it by forgoing your nick attack if you land your sneak attack with the Vex Weapon, but there is an opportunity cost associated with that over both using a better weapon for your main attack and the Cantrip damage you could otherwise have. It is not small potatoes either - If we are talking melee it is 13.5-32 damage on average you are losing for not using Green Flame Blade.
1. Stroke of luck has other applications
It does, but like I said above those other uses are not typically that powerful and often fail anyway. A natural 20 on a strength save is rarely going to succeed. A natural 20 on a Constitution save against a tough enemy is not going to succeed unless you really focused on boosting your Constitution.
The other saves you have proficiency, Evasion and more often than not Mage Slayer.
And you can even use it on the first miss to force a critical hit, when multi attacking in cases you really want the damage.
You can do this if you have Combat Prowess too. If you miss you can either make it a hit using no resources with Combat Prowess, or make it a critical hit using Stroke of Luck once a short rest.
The difference is the critical you get from stroke of Luck does quite a bit more damage if it was a Cantrip you used for the attack, because you are getting critical on the Cantrip dice too. Also you mentioned precision above - if you use a casting stat for the attack (Truestrike) and that stat is not maxed you are more likely to miss, meaning you will have the option to do this more frequently (until you use it), in addition to doing more damage whether you use it or not.
But this combination makes no sense! This sounds exactly like a badly optimized rogue who does not do the math.
Math does not account for situation or tactics. I get that at lower levels it theoretically leads to a small increase in damage (this is not true at high levels), but that math does not take into account the tactical implications of not being able to use a more effective Bonus action. Dual Wielder Feat on a Rogue rarely makes sense in a campaign because of the really strong Bonus Actions you have and the paltry damage it offers.
On an Arcane Trickster or Thief you are giving up your primary subclass abilities to Dual Wielder Feat in tier 1-2. On a Soul Knife or a Phantom you are giving up a major tier 3+ subclass ability and that is before you even consider Cunning action and Steady Aim which every Rogue has.
Maybe on an Assassin at low levels it makes sense, but even on an Assasin this is a particular build because you are talking about being in melee a lot and giving up cunning action. Even if you are throwing daggers you are still going to end up in melee a lot and without Cunning Action you are taking AOOs to get out of melee.
When it comes to optimization it is really about the Cantrips. Cantrips are not a bad option at any level, but at level 11+ nothing else the Rogue can do with Sneak Attack will really compete with them in play.
I am showing the damage of the combat prowess assuming a magical +1 weapon.
But what is the "rerolling" you are talking about. I am still not following what "rerolling" means in this context. There is no rerolling with Combat Prowess - you roll a natural 1 on the attack roll, it is a hit, no need to roll another die.