I can't really speak to Moon or Spirit bards these days, but Valor is better at combat, Lore is better at skills (which I play to), and Glamour is the better caster of the options.
Dance has grown on me because of how it plays in combat.
I find the class is poor at damage and kind of squishy, and makes up for it as a controller/ healer.
I still think Valor is the best classic bard, overall. The class / subclass combination combines skills, combat, and spellcasting solidly in a single package while maintaining bardic inspiration as a tool focused on supporting others. A build that either invests in two useful stats or works around them doesn't bother me. The armor training significantly helps mitigate squishiness.
Glamour really grew on me after the 2024 update. The previous version didn't really mesh as well for reasons on which I couldn't put my finger but the streamlining seems to have been effective for me.
Glamour exemplifies bards using illusions and enchantments as a common trope. I think the bonus spells known at an early level is an underrated benefit on a bard and that helps a lot. The abilities that use bardic inspiration as a resource take away from using it on others but these are good alternatives on which to use that resource. Mantle of Majesty tying up concentration locks out using it with other concentration spells, but the ability to spam Command as a bonus action is excellent.
Lore bards are a college I commonly play. Are they as good in combat as Valor or Glamour? Well, Cutting Words has it's moments and Magical Discoveries opens up the spell list faster than other bards so they definitely have benefits, but I think Valor and Glamour are stronger in combat. Fortunately the base class is still enough to carry.
Where I enjoy them at high level after Peerless Skill. This ability creates the confidence to try all kinds of things with skill checks. It also doesn't hurt that it's a strong accuracy benefit in combat for hitting with True Strike. A few more skill proficiencies over Jack of all Trades is a minor benefit but decent enough for me, and Cutting Words or Magical Discoveries are worthwhile, but it's Peerless Skill that does it for me. It's a fun college.
Those are my top choices.
Dance bards have definitely grown on me. The 3rd level abilities of a minor AC benefit and occasional free attack don't do much for me, and neither does evasion at 14th level, but the 6th level abilities are really useful. And the base class still has enough to carry.
That's my honorable mention.
