The Green Hermit
Hero
18. where are the magic item creation rules? in the dmg?
There aren't any creation rules, so to speak, but there's some easy to access information to help get a good feel for how to do this.
In the DMG, page 128, there is a Downtime Activity for crafting magic items. While it doesn't help you, as a DM, choose what goes on a magic item, it does give you a guideline based on rarity, with a price for said magic items.
There is also a pdf out there called 'Sane Magic Item Prices' or something along the lines, with player rebalanced cost of magic items, weighted for function in combat.
On top of that, I'd recommend taking a look at D&D Beyond. Here, you can see other player made magic items. The ones that are horribly flawed or right-out don't get many positive reviews, so you can filter the types of player-created magic items, and try to compare your own efforts to create magic items. Also, the template to -make- magic items on D&D Beyond is pretty cool.
Overall, though, it's suggested to look at sample magic items that already exist, and try to gauge how your own compare.
This. I wish there was a more specific set of rules, but it really is just a set of guidelines and then you have to figure it out for yourself. On the other hand, though, this gives each gaming group the flexibility to figure out how it works best for them.
just stumbled on something that opens up a can of worms in the description for the herbalism kit:
doesn't this imply that other magic items, or at least potions, can be crafted? if so, don't we need prices for those items? if a character with an herbalism kit can create a potion of healing, then certainly he/she can create a potion of greater healing, but no price for it is given.
Yes, just like magical items. Once again, the guidelines are in the Downtime section.