Jester David
Hero
I think I get your question.Good point.
By "poison" I mean things that trigger a Con save for additional damage.
I don't have a RAW reference for that. But Sage Advice seems to be clear that's the case (though without explaining exactly what rule that leads to this conclusion).
(If poison are to be doubled, I'm even more confused.)
Specifically, are secondary effects of attacks also doubled on a critical.
Such as the basilisk that does 10 piercing damage plus 7 poison damage on a hit versus a quasit whose tail does piercing damage and forces a save causing additional poison damage.
Most examples do seem to either be status effects or poison. But I can imagine an undead creature hitting with a slam and forcing a saving throw that causes additional necrotic damage.
I don’t see any hard rule clearly differentiating. The RAW answer is that anything tired solely to the hits is doubled, while anything with a save associated is a separate effect. As only the attack’s dice are doubled. They’re two related but distinct sources of damage.
Like a flaming arrow hitting a cask of oil. The arrow can crit, but the resulting side effect of an exploding arrow would have its own save and wouldn’t have dice doubled.
But that’s as much a “ruling” as RAW.
So the basilisk’s poison would be doubled as that is directly caused by the attack. It is the attack’s damage. But the quasit’s poison isn’t caused by the attack so it isn’t doubled.