Something I’ll change in my homebrew system!!!
But, just for notes, I’ve seen Samurai done as a good class. There are some fan-adaptations of the Final Fantasy series to table-top systems. They appear good to me. And, of course, there’s the series itself. But, in my honest opinion, it’s a concept too good to just throw it out of the window.
I have a problem with samurai as a
class because there's already one or more classes that cover most samurai concepts. You might need a new class if you're dealing with mystic samurai though. I don't see why Final Fantasy-style sword moves could not be powers or feats instead. A slayer with a feat that boost Power Strike (flavoring it as multiple sword swings, for instance, or as a single really fast strike) appeals to me. You don't need an entirely new class for such a concept.
D&D 3.0's "Oriental Adventures" did samurai pretty right. There was actually a class, but many of the NPC samurai were depicted as warriors or fighters, and could still take the Iajitsu skill and other samurai-specific abilities. I think things like
ki shouts were feats too.
OA had several clans (I think there were seven) each of which focused on a fighting style. The Crab Clan actually focused on non-traditional weapons better suited for killing setting-specific monsters. The Dragon Clan focused on dual-wielding, which I want to make a point about: dual-wielding among samurai were rare, and the wakizashi was normally used defensively, which is where the Complete Warrior samurai fell down,
but OA didn't deny the existence of dual-wielding samurai. It gave numerous options and let the player choose what they wanted.
Barring (mostly bad) flavor issues, leaving out the name, the Complete Warrior samurai seemed to exist solely so a fighter-type could dual-wield while wearing heavy armor and not having a high Dex score. The entire class could have been replaced with one new feat, "Armored Tempest Style" or something along those lines. Well, you would have to have one more feat for the weapon-that-levels-up-with-you but, again, make an ancestral weapon-style feat. You don't need a new class just for that.
I can't say I'm some sort of loremaster of Japanese history, but I like to think I read at least one more book than whoever wrote the Complete Warrior samurai. I distinctly recall reading about a battle that took place in the 1500s, where seven samurai got trophies: one of the samurai was using a bow, one got an award for first kill with a sword, and another got an award for first kill with a spear.