Worth spelling out your assumptions,
eloquentaction
Magic numbers are average damage with these penalities...
-0.1: Military
-0.2: Superior
-0.2: Load minor
-0.4: Two handed
...and these bonuses...
+0.5: Off-hand
+0.5: Ranged (any non-zero)
+1.0: Reach
High crit is factored in a bonus 5% of of the maximum damage, which is incorrect. That would imply that when you crit with a high crit, you maximize that high crit die/dice, which of course is not true.
Since I also disagree that military melee should be penalized because ANY class that wants to use a melee weapon is going to at least have military melee (OK, so Clerics don't, but then you might as well just get the bastard sword).
After adjustment, the Halberd and Longspear come out on top, which shows that unless you REALLY think reach is the bomb, the formula is flawed.