Reply to thread

Message

<blockquote data-quote="shieldfoss" data-source="post: 7202404" data-attributes="member: 6903301">Found the error.Compare Thri-Kreen Weapon Mastery with Valenar Weapon Training.First the rules text, then the XML implementation (just so you can see they should be identical, but are not:The wording in the short descriptions:Gain proficiency, +2/+3/+4 (by tier) to damage with scimitars, double scimitars, and falchionsProficiency and +2/+3/+4 bonus to damage with gythka and chatkcha.Logically identical wording.Now the code:[code]&nbsp; &nbsp; &lt;RulesElement name=&quot;Valenar Weapon Training&quot; type=&quot;Feat&quot; internal-id=&quot;ID_FMP_FEAT_2794&quot; source=&quot;Dragon Magazine 385&quot; revision-date=&quot;8/27/2010 12:20:38 PM&quot;&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;Prereqs&gt; Elf &lt;/Prereqs&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;print-prereqs&gt; Elf &lt;/print-prereqs&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;specific name=&quot;Tier&quot;&gt; Heroic &lt;/specific&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;specific name=&quot;Short Description&quot;&gt; Gain proficiency, +2/+3/+4 (by tier) to damage with scimitars, double scimitars, and falchions &lt;/specific&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;specific name=&quot;Special&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;specific name=&quot;type&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;specific name=&quot;Associated Power Info&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;specific name=&quot;Associated Powers&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;rules&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;grant name=&quot;ID_INTERNAL_PROFICIENCY_WEAPON_PROFICIENCY_(SCIMITAR)&quot; type=&quot;Proficiency&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;grant name=&quot;ID_INTERNAL_PROFICIENCY_WEAPON_PROFICIENCY_(DOUBLE_SCIMITAR)&quot; type=&quot;Proficiency&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;grant name=&quot;ID_INTERNAL_PROFICIENCY_WEAPON_PROFICIENCY_(FALCHION)&quot; type=&quot;Proficiency&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Valenar Weapon Training&quot; value=&quot;+2&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Scimitar:damage&quot; value=&quot;+Valenar Weapon Training&quot; type=&quot;Feat&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Double Scimitar:damage&quot; value=&quot;+Valenar Weapon Training&quot; type=&quot;Feat&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Falchion:damage&quot; value=&quot;+Valenar Weapon Training&quot; type=&quot;Feat&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Valenar Weapon Training&quot; value=&quot;+1&quot; requires=&quot;Paragon Tier&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Valenar Weapon Training&quot; value=&quot;+1&quot; requires=&quot;Epic Tier&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;/rules&gt;You gain proficiency and a +2 feat bonus to damage rolls with scimitars, double scimitars, and falchions. The bonus increases to +3 at 11th level and +4 at 21st level.&nbsp; &nbsp; &lt;/RulesElement&gt;[/code][code]&nbsp; &nbsp; &lt;RulesElement name=&quot;Thri-Kreen Weapon Master&quot; type=&quot;Feat&quot; internal-id=&quot;ID_FMP_FEAT_3768&quot; source=&quot;Dragon Magazine 411&quot;&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;Prereqs&gt; Thri-kreen race &lt;/Prereqs&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;print-prereqs&gt; Thri-kreen &lt;/print-prereqs&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;Flavor&gt; The sacred weapons of the thri-kreen are like deadly extensions of your body. &lt;/Flavor&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;specific name=&quot;Tier&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;specific name=&quot;Short Description&quot;&gt; Proficiency and +2/+3/+4 bonus to damage with gythka and chatkcha. &lt;/specific&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;specific name=&quot;Special&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;specific name=&quot;type&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;specific name=&quot;Associated Power Info&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;specific name=&quot;Associated Powers&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;rules&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;grant name=&quot;ID_INTERNAL_PROFICIENCY_WEAPON_PROFICIENCY_(GYTHKA)&quot; type=&quot;Proficiency&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;grant name=&quot;ID_INTERNAL_PROFICIENCY_WEAPON_PROFICIENCY_(CHATKCHA)&quot; type=&quot;Proficiency&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Thri-kreen Weapon Master (Gythka)&quot; value=&quot;+2&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Thri-kreen Weapon Master (Gythka)&quot; value=&quot;+1&quot; requires=&quot;Paragon Tier&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Thri-kreen Weapon Master (Gythka)&quot; value=&quot;+1&quot; requires=&quot;Epic Tier&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Gythka,weapon:damage&quot; value=&quot;+Thri-kreen Weapon Master (Gythka)&quot; type=&quot;Feat&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Thri-kreen Weapon Master (Chatkcha)&quot; value=&quot;+2&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Thri-kreen Weapon Master (Chatkcha)&quot; value=&quot;+1&quot; requires=&quot;Paragon Tier&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Thri-kreen Weapon Master (Chatkcha)&quot; value=&quot;+1&quot; requires=&quot;Epic Tier&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;statadd name=&quot;Gythka,weapon:damage&quot; value=&quot;+Thri-kreen Weapon Master (Chatkcha)&quot; type=&quot;Feat&quot; /&gt;&nbsp; &nbsp; &nbsp; &nbsp; &lt;/rules&gt;&nbsp; &nbsp; You gain proficiency with the gythka and the chatkcha.&nbsp; Additionally, you gain a +2 feat bonus to damage rolls with these weapons.&nbsp; This bonus increases to +3 at 11th level and +4 at 21st level.&nbsp; &nbsp; &lt;/RulesElement&gt;[/code]Not quite identical! In particular, notice:&lt;statadd name=&quot;Scimitar:damage&quot; value=&quot;+Valenar Weapon Training&quot; type=&quot;Feat&quot; /&gt;&lt;statadd name=&quot;Gythka,weapon:damage&quot; value=&quot;+Thri-kreen Weapon Master (Gythka)&quot; type=&quot;Feat&quot; /&gt;&lt;statadd name=&quot;Gythka,weapon:damage&quot; value=&quot;+Thri-kreen Weapon Master (Chatkcha)&quot; type=&quot;Feat&quot; /&gt;The scimitar is how it's supposed to be.The first line, for Gythka, accidentally only adds to weapon damage.The second line, for Chatkcha, accidentally adds to Gythka damage! And also only to weapon damage.Now that's something easily fixed for me because I can just fix my local .part file, but do you know if there's somewhere I can report the bug to?</blockquote>

[QUOTE="shieldfoss, post: 7202404, member: 6903301"] Found the error. Compare Thri-Kreen Weapon Mastery with Valenar Weapon Training. First the rules text, then the XML implementation (just so you can see they [I]should[/I] be identical, but are not: The wording in the short descriptions: Gain proficiency, +2/+3/+4 (by tier) to damage with scimitars, double scimitars, and falchions Proficiency and +2/+3/+4 bonus to damage with gythka and chatkcha. Logically identical wording. Now the code: [code] <RulesElement name="Valenar Weapon Training" type="Feat" internal-id="ID_FMP_FEAT_2794" source="Dragon Magazine 385" revision-date="8/27/2010 12:20:38 PM"> <Prereqs> Elf </Prereqs> <print-prereqs> Elf </print-prereqs> <specific name="Tier"> Heroic </specific> <specific name="Short Description"> Gain proficiency, +2/+3/+4 (by tier) to damage with scimitars, double scimitars, and falchions </specific> <specific name="Special" /> <specific name="type" /> <specific name="Associated Power Info" /> <specific name="Associated Powers" /> <rules> <grant name="ID_INTERNAL_PROFICIENCY_WEAPON_PROFICIENCY_(SCIMITAR)" type="Proficiency" /> <grant name="ID_INTERNAL_PROFICIENCY_WEAPON_PROFICIENCY_(DOUBLE_SCIMITAR)" type="Proficiency" /> <grant name="ID_INTERNAL_PROFICIENCY_WEAPON_PROFICIENCY_(FALCHION)" type="Proficiency" /> <statadd name="Valenar Weapon Training" value="+2" /> <statadd name="Scimitar:damage" value="+Valenar Weapon Training" type="Feat" /> <statadd name="Double Scimitar:damage" value="+Valenar Weapon Training" type="Feat" /> <statadd name="Falchion:damage" value="+Valenar Weapon Training" type="Feat" /> <statadd name="Valenar Weapon Training" value="+1" requires="Paragon Tier" /> <statadd name="Valenar Weapon Training" value="+1" requires="Epic Tier" /> </rules> You gain proficiency and a +2 feat bonus to damage rolls with scimitars, double scimitars, and falchions. The bonus increases to +3 at 11th level and +4 at 21st level. </RulesElement>[/code][code] <RulesElement name="Thri-Kreen Weapon Master" type="Feat" internal-id="ID_FMP_FEAT_3768" source="Dragon Magazine 411"> <Prereqs> Thri-kreen race </Prereqs> <print-prereqs> Thri-kreen </print-prereqs> <Flavor> The sacred weapons of the thri-kreen are like deadly extensions of your body. </Flavor> <specific name="Tier" /> <specific name="Short Description"> Proficiency and +2/+3/+4 bonus to damage with gythka and chatkcha. </specific> <specific name="Special" /> <specific name="type" /> <specific name="Associated Power Info" /> <specific name="Associated Powers" /> <rules> <grant name="ID_INTERNAL_PROFICIENCY_WEAPON_PROFICIENCY_(GYTHKA)" type="Proficiency" /> <grant name="ID_INTERNAL_PROFICIENCY_WEAPON_PROFICIENCY_(CHATKCHA)" type="Proficiency" /> <statadd name="Thri-kreen Weapon Master (Gythka)" value="+2" /> <statadd name="Thri-kreen Weapon Master (Gythka)" value="+1" requires="Paragon Tier" /> <statadd name="Thri-kreen Weapon Master (Gythka)" value="+1" requires="Epic Tier" /> <statadd name="Gythka,weapon:damage" value="+Thri-kreen Weapon Master (Gythka)" type="Feat" /> <statadd name="Thri-kreen Weapon Master (Chatkcha)" value="+2" /> <statadd name="Thri-kreen Weapon Master (Chatkcha)" value="+1" requires="Paragon Tier" /> <statadd name="Thri-kreen Weapon Master (Chatkcha)" value="+1" requires="Epic Tier" /> <statadd name="Gythka,weapon:damage" value="+Thri-kreen Weapon Master (Chatkcha)" type="Feat" /> </rules> You gain proficiency with the gythka and the chatkcha. Additionally, you gain a +2 feat bonus to damage rolls with these weapons. This bonus increases to +3 at 11th level and +4 at 21st level. </RulesElement>[/code] Not quite identical! In particular, notice: <statadd name=[B]"Scimitar:damage"[/B] value="+Valenar Weapon Training" type="Feat" /> <statadd name=[B]"Gythka,weapon:damage"[/B] value="+Thri-kreen Weapon Master ([B]Gythka[/B])" type="Feat" /> <statadd name=[B]"Gythka,weapon:damage"[/B] value="+Thri-kreen Weapon Master ([B]Chatkcha[/B])" type="Feat" /> The scimitar is how it's [I]supposed [/I]to be. The first line, for Gythka, accidentally only adds to weapon damage. The second line, for Chatkcha, accidentally adds to [I]Gythka[/I] damage! And also only to weapon damage. Now that's something easily fixed for me because I can just fix my local .part file, but do you know if there's somewhere I can report the bug to? [/QUOTE]

Verification