Aha! My treasure chest has arrived. It's awesome!
that is cool. definitely sound advice to not let players take the props home. Though these are cheaper, loss of materials still is a hit.
One thought to consider, to keep from having to truly horde up all the money a party of PCs will ever earn, is to setup a form of banking or storage, such that a player can hand you 1,000 GP and say he stores it in his treasure vault at the castle or some such.
In this way, the GM get's 1,000 GP of coins back for re-use in the next treasure horde, and players aren't accumulating and carrying 1 million gold coins because that's what their PC has.
Basically, a bit of a hybrid of the coins as money and the old-style paper accounting.
Assuming some maximum threshold of practical carrying capacity for gold, it would limit the need to actually buy enough coins to model ALL the wealth the party could possibly aquire.
How far are you going with the real props for gear thing? Rings, wands, rods and staff?
I used a card system for my own PC's gear. it worked alright, but in some ways was more cumbersome than the traditional char sheet.
In some ways, I think a game with less treasure/magic items would work well, because it is easier to model with physical props (less items to buy/make) and it's rarity keeps each item special.
I forget if you linked where you ordered the plastic money and gems from, but it sounds like you found a pretty good cheap source.
Tell us how the gaming turns out with this phat loot