I'd say trafficking in souls for your own benefit is evil, yes. Even if the souls are evil, that's literally the business of Devils and Night Hags. Just because the souls are in handy coin form rather than wriggling Larvae doesn't make it less evil.
Also worth noting that only evil creatures...