Back in the old days they were there to kill the PCs.
Now, I’m not sure. If I placed a save or die trap in a dungeon now, I’m sure it would cause a kerfuffle. I recently used what I thought was a neat puzzle to unlock a secret door, but really it did not accomplish anything in the game (I did...