@AbdulAlhazred I have no issues with your analyzation of the game above, In fact it pretty much aligns with how I am reading what happened as well. My issue is with 2 things specifically, the claim that the outcome for failure was foreshadowed to the point that the player knew his risk vs his reward. If the player had known the risk was a soul-sucking painting... or even an attack by the painting would he have made the same choice? I don't know, but if you have no clue what the outcome of failure will be outside of...some bad stuff...does that diminish the meaningfulness of that decision? Again I don't know but if the GM is making it up on the fly after the roll it kind of feels that way to me.
My second issue is that I am failing to see how more agency in this example is being exerted than in a D&D session. The player is looking for something... the DM decided if it was or wasn't there, a roll to figure out if it was magical was made and failure = trap sprung. PC and party attacked. I'm trying to see where the extra agency came in here... where the player shaped the story.