Great
Aurora's Whole Realms Guide - feels like looking at a Sears & Roebuck catalog for FR, lots of nice little worldbuilding tidbits (though the Whole Realms "company" itself is silly)
Elminster's Ecologies - lots of in-depth detail on monsters to make them living, breathing creatures that is inspiring in making you want to incorporate them.
B4 - Lost City - very evocative and different from your typical dungeon crawl. Could be used as an entire campaign unto itself. All Hail Zargon!
Forgotten Realms Campaign Set (Grey box) - A nice, in-depth tour of the Realms that is a goldmine for worldbuilding.
World of Greyhawk Set ('83) - A wonderful campaign set that isn't heavy on details, letting you flesh it out as you choose with several interesting world building opportunities.
S2 - White Plume Mountain - A good mix of combat, tricks and traps. Though it's got powerful prizes, Stormbringer - I mean, er, Black Razor is always fun.
Bad
B8 - Journey to the Rock. A confused mess of a module, though not as bad as Forest Oracle. Three railroad paths to choose from and the plot is exceptionally weak.
Roots of Evil - Unfortunately, a lot of 2E adventures were railroads, and most of the Ravenloft adventures started you out by killing everyone in the party. This one is probably the most egragrious*, and though it gets better after the opening, it's still a railroad and (bad) rehash of elements of the original Ravenloft I6.
The Horde/Maztica/Kara-Tur - While I like campaign worlds set in other cultures, these made the mistake of trying to hew too closely to historical counterparts and the text for these sets is just drab and boring. If the fantastic elements of these cultures - and more engaging writing - had been used, they wouldn't have fallen here. Contrast this to Al-Qadim, which I think was done better as it embraced the sword & sandal genre instead of trying to be a dry copy of Arabia.
* Though in truth, Vecna Lives probably has the title for doing this, though it's use is probably the most original and actually works because they aren't your own characters...