Voadam
Legend
I read this 5e advice completely differently. The 5e advice seems to be don't call for a check if there is nothing really to check about, if it is going to succeed (like walking across a room) or it is just not going to work (shooting the moon with an arrow).I'm a believer that dice should not be rolled unless there is a consequence for failure. (5e even explicitly says this, although everybody ignores it.). And while those consequences aren't necessarily a disaster, they should at least be undesireable.
And, no, failing to find a secret door, or not recalling a bit of lore, or having that door continue to be locked, are not consequences of failure because those conditions existed before they rolled.
When players get used to the idea that dice rolling is risky, they tend to rely less on "using" a character skill, and they tend to use, well, player skill. Asking questions, trying things that don't require rolls, etc.
Which, among all the possible playstyles, is what I'm trying encourage at my table, and is also the kind of table at which I want to play.
14 DMG page 237:
USING ABILITY SCORES
When a player wants to do something, it's often appropriate to let the attempt succeed without a roll or a reference to the character's ability scores. For example, a character doesn't normally need to make a Dexterity check to walk across an empty room or a Charisma check to order a mug of ale. Only call for a roll if there is a meaningful consequence for failure.
When deciding whether to use a roll, ask yourself two questions:
Is a task so easy and so free of conflict and stress that there should be no chance of failure?
Is a task so inappropriate or impossible- such as hitting the moon with an arrow-that it can't work?
If the answer to both of these questions is no, some kind of roll is appropriate. The following sections provide guidance on determining whether to call for an ability check, attack roll, or saving throw; how to assign DCs; when to use advantage and disadvantage; and other related topics.
Searching for a secret door is not so easy there is no chance of failure or so impossible it can't work.
Searching for a secret door is therefore something where a roll is appropriate if the DM wants one.
Not spotting a secret door completely seems a consequence of failing a check in this context.