It seems simple enough; I'd agree an attack is when you roll to hit, but there are corner cases where the term 'attack' becomes confusing.
Example:
A warlord in my party has the power Death From Two Sides, which allows himself and an ally to make a melee basic, and "if both attacks hit, the...