I try to run games that I would enjoy playing in, so my answer doesn’t really change from DM perspective vs player perspective. I like XP for combat, non-combat challenges, and completing story/quest goals, which one might describe as “milestones.” I am also not opposed to XP for discoveries...