soulcatcher
First Post
Taurendil said:I had a quick read, seems like you've put a lot of thought into this. Can't say I understand everything right now. I need to read some of the links (not that familiar with graph theory) and propably have a better understanding of the rest of the codebase. Not being a native english speaker doesn't help either. Are there other documents about the current architecture and such? e.g. What are Tokens? Are they the code representation of the LST tags?
Most of the general assumptions are inline with what I try to use myself on projects.
I'm looking for an easy intro to the project. Do you have a team that does Unit Tests (or other tests)? Seems like a good way to get started without getting in over my head. I'm familiar with unit testing under php using simpletest, should be similar to JUnit.
But maybe this conversation shouldn't be held in this thread. So show me the way...
You can subscribe to the developers list at https://lists.sourceforge.net/lists/listinfo/pcgen-devel
After you are set up there, we can get you sourceforge access and get you some more explanation of how things work.
I agree that this is now getting off topic of this thread enough that we should take it offline. But, I'll answer those questions real quick like:
Architecture Docs: No, the old code didn't really have any documentation, this is the first real attempt to really get a firm architecture in place. That being said, between myself and the others, we can probably explain a fair beit to you.
Tokens: Every LST command is it's own plugin. You can find them all in separate jar files in your plugins/lstplugins folder. Other tokens we use are jepplugins (for formulas), bonusplugins (for bonuses), outputplugins (for tokens used on export sheets like pdf), and systemlstplugins (tokens used for setup of the interface/game modes).
There are still some tokens trapped in the rest of the code, and we need to pluginize them, or deprecate them before we hit 5.12, so that we can know that all of the tokens we use can be permanently supportable. (for those listening here, this is partially so that we can permanently support old CMP lst files.)
Entry to the team/junits: Yes, we do junits, and are always happy to get more. our present coverage is I think in the 50-60% range. Junits are a great way to get started, but also helping to finish the above tokenization effort is a good place to start as well.
Welcome to the team

Devon