Not sure exactly what I want out of crafting. I'd like there to be something so that picking up skill in some artisan tools doesn't feel like it is just background. What I don't want is for players to be able to just take a couple weeks of downtime to craft a sword and attach magical effects to it just because they're a blacksmith. I don't even really use the rules for such in 5e where you spend X weeks of downtime crafting rare or legendary items, instead I go back to 2e where magical items need exotic materials to craft. Basically, I don't want to go back to 3e or 4e where everyone just makes whatever items they want because they have the feats, kinda ruins a part of the game to me.