I just checked back and caught that Insightful Fighting can be activated at any range, so that does make it a lot more useful. Bumps the archetype up to black as well overall, I'd say.
Yea, pick one or the other.
The more warlock, the better booming blade is, since it auto-scales.
The more rogue, the better multi-attack is, since you scale by sneak attack.\
Xanathar's updates are up. Scout is good (very good at higher levels). Inquisitive is not.
Also the few new spells Arcane Tricksters get access to are meh for the most part.
Find Familiar: Conjuration; 1 hour; V,S,M*. No reason to take any other spell with your free choice at this level. All the advantage you could ever want is there for the taking, via the familiar's Help action that requires none of your own actions. (The Owl's Flyby is especially good for that.) And then there's the also-awesome-for-scouting ability to see and hear through your familiar up to 100 feet away.
If you use the attack-aiding option in Help, the next ally who attacks the target gets the benefit.
Something I've found in my further readings that's important to keep in mind, is that due to the familiar rolling it's own initiative it's not actually "all the advantage you could ever want" since their help action gives advantage to the next player, which may not be you.
The Rogue can Ready their action for when the familiar uses Help, however. Thus getting the advantage from it that way.
The Skulker feat is red? Really?? You don't think negating disadvantage on Perception rolls in dim light is even worth a mention here?
TWF benefits from the increased chance to land sneak attacks and to crit with sneak attacks.
Can you tell us your methodology for crits for this table? Because that statement above does not seem possible within the rules whihc makes me question your entire table.
Yeah, I get slightly lower numbers for TWF, I'm guessing because of the crit calculation. I also get slightly higher numbers for BB starting at Level 9; I'm not sure what that's about. The bottom line still holds that TWF yields slightly higher DPR at all levels if you ignore the possibility of BB's secondary damage, significantly so in Tier 1, but by the time BB starts to scale, the gap is pretty small as a share of the average damage; small enough that IMO the combination of the control effect and being able to do something else with your bonus action is well worth it.
TWF (level 5)
Main Hand (base damage): (1d6 + 4) * 0.6 = 4.5
Main Hand (crit damage) : 1d6 * 0.05 = 0.175
Off Hand (base damage) : 1d6 * 0.6 = 2.1
Off Hand (crit damage) : 1d5 * 0.05 = 0.175
Sneak Attack (base) : 3d6 * (1 - 0.4*0.4) = 8.82
Sneak Attack (crit) : 3d6 * (0.05 + 0.4 * 0.05) = 0.735
Total: = 16.51
This observation is accurate. There is a way to compute the crit chance to account for this as covered by @Esker.You can't roll both your Attack action, take your Bonus Attack action, and then determine which to apply your sneak attack. Roll your attack, if it hits decide to add SA or not, and then roll damage. There seems no way to crit hunt SA with TWF.