No one favorite edition for me, but here's what I like best from each edition:
Rules Cyclopedia. A complete game in one book.
1e. Gygax's DMG with all those tables.
2e. The settings.
3e & PF. Character customization.
4e. Easier for the DM.
5e. I don't know yet, but I like its ambitions.