[RPG] Creating Monsters!

[Kalanyr]

No, it'd take longer, he uses arrays. I just don't have enough free time at the moment to learn PHP.

 

[Zappo]

So RPG is a one-man effort? Pretty good. It makes the fact that it doesn't work outside IE rather understandable.

I can see the developer not having time to do good balance. We are hopefully good at that, though.

 

[Creamsteak]

OK, am I the ONLY person in the world forced to write huge comments for my programs? I always call it pointless on my assignments, but it sure would help me find what I'm looking for in this. If things were commented as thoroughly as they force me to, I could probably spot what I'm looking for. I 'think' I did find it... but all of the attacks are just listed under the heading "Calculate Attack Data" (and there are a lot of different ones, like 50) and I think it could be described better.

--Frustrated, probably because I don't know what I'm looking at .

 

[Kalanyr]

Yeah it is quiet commendable. He doesn't use enough comments/preconditions/postconditions statements if this is supposed to be fairly customisable though (ie he uses only comments and not enough of them).

 

[Kalanyr]

It looks to me like there should be a seperate database file containing summon stats. I'm guessing he hasn't fully implemented it yet which is why summons are all identical.

 

[Morrus]

I'd be interested in seeing the magic system altered in some way. Say, using MP as the base for determining attack/defence.

Also, presumably the battle hit/damage formula can be changed? Can anyone see where the calculation itself is?

 

[Kalanyr]

Yeah, I can see what it is. It's repeated a lot of times for different attack circumstances (bot vs player, bot perspective, bot is using magic, is seperate from bot vs player, bot perspective, bot is using a phyiscal attack (there's 16 different attack codes) but it's a random Integer between 1 and your attack - 1/3 of your opponents defence for normal attacks.

Edit: To find the start of the relevant section do a search for: // Calculate Attack Data , the actually attack defence stuff looks like this: (it probably varies for different attack types though haven't looked thoroughly (if it doesn't it SHOULD)).

$hp_dmg=rand(1,$P2['bot_str']);
// Opposition Defence
$def=$P1['def']/3;

$hp_def=rand(0,$def);
$hp_dmg=(int)$hp_dmg;
$hp_def=(int)$hp_def;
$hp_dmg=$hp_dmg-$hp_def;
if($hp_dmg<0){$hp_dmg=0;}
$mp_dmg=$hp_dmg/2;
$mp_dmg=(int)$mp_dmg;
if($mp_dmg<0){$mp_dmg=0;}

 

[Creamsteak]

It looks to my unskilled mind like he doesn't have attack/defense method, but repeats the same code for each instance of it. Bothers me a bit, if I'm right, because it intentionally slows down attempts to change that.

 

[Zappo]

I used to often write some code for a university exam or project or whatever, fully knowing that it has no actual value, and it will never be used again after the marking, and the teacher will only see the program running, and I don't need to comment it.

And I always end up either having to reuse it after one year, or having to give it to someone else.

And I always mentally kick myself for not having used comments.

CS, if they force you to write huge comments, they are doing their job right. I know I still don't do enough of them.

 

[Kalanyr]

Yeah, it looks to me like he should be using method calls too, CS. I'm not sure if its deliberate or if he just decide it was easier to copy and paste it than to set it up as a method. There's a few things in there where he's taken shortcuts that'd get you murdered in University assessment.