My current in use dice are carried in several Gamer's Bag bags that I have bought over the last couple of years.
All my extra dice are in a big tupperware box about the size of two shoeboxes.
I have a multi-colored cloth bag that my grandmother made for me many years ago. I also have a small leather pouch that my friend bought for me in Mexico. I also use the original plastic boxes that some of my dice sets came in.
Other things I've seen people use:
ziplock bags
cloth bags
chainmail bags
Crown Royal bags are really popular.
intricate wooden boxes
fishing tackle boxes (also good for miniatures)
A red leather Bag of Dice Holding™ from the Gamer's Bag (www.thegamersbag.com, wonderful people there) with a custom dragon's eye design embroidered in gold thread. Inside are eight seperate pockets for my dice along with a few extra sets in smaller pouches and a few good luck charms (a mini magician tarot card, a piece of green adventurine, lucky 1934 penny, ect.)
Last session a fellow player showed up with her dice in a crown royal bag and I told her that it was an "old school" gamer's bag. She didn't get it. I explained to her that gamers had been using crown royal bags to carry their dice for decades. She thought it was her idea.