What the Pathfinder community has done with their Foundry mods is just amazing. Makes me jealous. Not enough to buy a whole new set of books for a new fantasy TTRPG, but I've thought about it. I've not used the adventure muncher because I've been running third-party adventures. I should test it out though. I always figured that if I were to run a WotC adventure, I would switch to Roll20, even if I have to re-buy the materials. Just having all the VTT prep work done for me would make it worth it. Foundry is my preferred VTT, however, when it comes to content I have to set up myself. Prepping maps is just so much easier than every other VTT I've tried and I've tried and tested MANY of them. It makes up for Foundry's lack of manual FOW reveal, which is what kept me from going with Foundry originally (and keeps me paying attention to other VTTs).
As for Hero Lab, I'm a bit sad to hear that it is lacking for PF2. I've not really paid any attention to Lone Wolf Development since they stopped supporting RealmWorks. The lack of an official license for 5e made Hero Lab too much work to use with 5e after awhile, even with the great community volunteer content. I like to root for small developers, but if they are going to put all their eggs in the Pathfinder basket, they really need to provide the best tools for Pathfinder. Even if they did though, the move to VTTs is going to cut deeply into their user base. A lot of people don't want to manage character sheets outside of their VTT.
FWIW, I have done all of my gaming via VTT since 2011. Initially, it was on D20 Pro. I did flirt with Fantasy Grounds 1 and 2 as well. I have played via Roll20, but won't use it to GM (it's too limited for my tastes). Combine technical limitations with higher cost? Not for me.
In terms of Foundry VTT, I've used it for both PF1, PF2, Starfinder as well as 5e. The PF2 core rules system (being based on the OGL) means Foundry VTT is better for PF2 than it is for 5e, but with Mr. Primate's plug-in for DDB importer, together with Automated Animations + Jules and Ben's Patreon animations - my own sound effects - and Midi-QOL turned up to max? (not to mention a couple of dozen other modules) It's really
quite impressive what Foundry can do. With some sharp overhead tokens and using a high quality map (I prefer Heroic Maps whenever possible) the visual fidelity and ease of use for 5e in Foundry VTT is exceptional. It's my main hobby and I have no difficulty in paying for stuff that works and is fun to use.
I would never go back to face-to-face gaming for a number of reasons that are peculiar to my own circumstances (travel time is a
killer for me), but even if that was not true, the benefits that DDB provides to Foundry VTT are excellent and well worth it to me and my group. I appreciate that others prefer face-to-face gaming for social reasons - and others just want a book in hand and to roll some bones at the table among friends. That's fine; I get it.
From my perspective, Foundry VTT let's me do all of that without the huge downside of travel to and from the game. For me? It's been great.