It makes sense in the sense that D&D uses it, in fights against other creatures.its worse still because there is nothing about Strength that says "Can hit more accurately" by any common understanding
Strength is, at base, the capacity to exert force. When using a weapon, that translates to greater speed of striking (giving an opponent less chancer to react) and more control (allowing changes of direction and such more rapidly). That does mean that you are able to strike an opponent better, even before you start getting into D&D's AC system where you may need to strike through tough hide to "hit".
Yep. This is why Battlemasters and Paladins (and other spellcasters) are often more effective than Champions. Over the course of a long adventuring day, the extra crit chance of the champion may mean that they technically deal more overall damage, but the ability to dump resources when and where you really need them is more valuable.Yep. An active feature which allows you to be extra killy when you need it and/or when you're in optimal position is in practice much better than a passive boost that makes you always a bit better whether you need it or not.