Excuse my misunderstanding, as it did seem the only possibility given that you were saying the rest of us aren't supposed to point out when the feat isn't a viable damage boost.
I see where the confusion seems to lie.
When comparing the DPR of the -5/+10 boost vs. +2 strength, it is clear and unquestioned that the times when the -5/+10 option isn't used that the +2 strength has superior DPR, since it is both more accurate and more damaging.
So that means that all we need to know is A) how much the use of the -5/+10 actually improves DPR in those occassions that it is an improvement, and B) how many situations in which the use of the -5/+10 improves damage vs. how many it doesn't.
That is why the comparisons are done in the way they are, assuming use of the -5/+10 even though it might not be enhancing DPR against that particular AC, because the result then tells us either that this is a situation where there is a boost and how much that boost is, or that this is a situation where the feat is not providing a damage boost.
So no, it isn't a mistake to do the comparisons that way - though there can be a mistake made in assuming how frequently a particular AC is or isn't going to come up in a campaign, since that assumption might match one campaign, but not another.
Ah, okay. Yes of course you should calculate the dpr against, say, AC 25.
But only to conclude the feat isn't going to be used then. So the actual dpr number should not be included in the "average dpr". Not saying you make this mistake, but I have seen it been made.
The next step, then. Yes, above the cutoff point "it is clear and unquestioned that the times when the -5/+10 option isn't used that the +2 strength has superior DPR, since it is both more accurate and more damaging".
Absolutely true. But it is also unquestionably true that the difference here is slight, since we're talking about -1 to hit and -1 to damage.
So if the the feat, when it does turn on (below the cutoff point), provides a much larger benefit than what is lost when it is not turned on, then the feat can still provide a massive benefit.
And the way to calculate this isn't simply to pit the gains from AC 11 and 12, say, against the losses from AC 18 and 19 (again, very simplified).
But it is to gauge the number of rounds where you are attacking something with AC 11 and 12, versus the number of rounds where you attack something with AC 18 or 19. And remember, each round vs AC 11 covers a lot of rounds vs AC 19, simply because the gain vs AC 11 is much larger than the loss vs AC 19. (Again, in our ruthlessly simplified scenario only used to make my point come across)
It is to this point few if even one analysis has reached. And any analysis that doesn't get here is simply not a good basis for discussion and evaluation.
It is now that I am telling you and everybody else that a correctly played GWM or SS character will dominate big in many cases, while not suffering especially much in some.
First thing: the cutoff point is not as low as the straight-forward analysis would have you believe.
So you can't dismiss the claim simply by saying "sure against zombies it's great". At higher levels (where the feat really start coming into its own, since its damage potential is no longer 8,5 or even 17 points of damage, but 25 or even more) many monsters still have AC lower than 15. And against monsters with AC near or past the cutoff point, you can employ a long list of boosters whose effects are balooned by this feat.
Taken by itself, something like the bonus given by Bards or Battlemasters or Clerics seem decent enough. Or advantage (from any of a great number of choices). But when combined with the ability to deal +10 damage, the balance is blown clean out the water.
Then it's no longer just weak or clumsy monsters you gain a hefty damage bonus against, but many monsters.
So many in fact, that if you're a martial character that does not choose either of these feats, you will have to resign yourself to being severely outdamaged in way too many fights.