Personally, I consider Shadow of the Demon Lord's Boons and Banes to be a better take on advantage/disadvantage. Blades in the Dark's clocks are an elegant evolution of the skill challenge mechanic (which I can't understand why 5e dropped after years of iteration and improvement), and 4e making all spells use attack rolls while saving throws were specifically to end ongoing effects was brilliant.
What about you?
What about you?