I have a favorite weapon in Quake, it's the rocket launcher. I also like how Quake as a game is set up, that I'm not going to always have access to the rocket launcher or might want to keep in my back pocket for a quick escape, so I'd better also learn how to use all the other weapons.
Is that bad? Is that the game telling me that my fun is bad and wrong and stupid? Or is it the game making me consider my moves, and manage my ammo and positioning?
Sifu, the best action game in the history of action games, has weapons breaking all the time and it's aggressively fun. Granted, unlike BotW your best weapon in Sifu is your bare fists, but I can certainly see a less kung fu game having a mediocre unbreakable fallback option.
Is it, really? Because the way I see it, most of the time, people pretty quickly realize what weapon + perk combination is the best one, and never reach for anything else. And something is always going to be the best.
I think caster vs martial disparity is overstated, but I'm totally on board with screwing the mages over too. Hate their guts.
Vancian casting where you have to assign specific spells to slots when preparing spells is very similar to what I'm proposing for weapons breaking -- you are often forced to just deal with the hand dealt to you. "Yeah I fireball would be really nice here, but I only have Fly prepared".