I tend to favor German accents for my dwarves. Or a really, rally bad Scandinavian accent.My dwarves don't have a Scottish accent. Some people from Scotland have a dwarven accent.
I've had players use bad Scottish accents for their dwarves. I think I saw this trend with Warcraft became popular.The only place I've seen Scottish dwarves is Critical Role, I think. I like my dwarves with a northern English accent (that's how they're always portrayed in Warhammer computer games).
I'm of the opinion that most tropes are neither good nor bad. You can take an overused trope, like saving the princess, play it straight and still make a good story. You could subvert the trope and end up making a bad story. The trope itself usually isn't the problem.I like a good trope. Sometimes I even like a bad trope. It depends on how it's done in the moment.