No, it should be a sack of goodies. You should feel substantially more powerful when you take one. Taking a feat is a BIG decision. You only normally get 5, 6 if you're human.
The fact that it provides flavor does not excuse it from being a crap feat. Flavor feats should be as good as stat increases, or honestly even better. You want to reward people for making their character unique, not penalize them for it.
I mean, if Elemental Adept was exactly the same text, but let you treat every 1 on the damage roll as a max result, it would provide EXACTLY the same flavor ("Look, I'm an Ice Mage! Let it go, let it go!") but would actually make me think hard about not taking +2 Int or +2 Cha to get it. If I had already wanted to play an ice mage, then it becomes a no-brainer. That's what should be the standard.
If I don't care about a particular flavor, than weighing the options should be difficult.
If I do care about flavor, than the feat should become a no-brainer, because it provides flavor and comparable effectiveness.
Any "ice mage" feat or "I'm super durable" feat that isn't the obvious mechanical choice to represent that concept is subpar.