In the first 2 examples here of Stark and Elric, the author quickly comes up with a way for them to become functioning heroes. Sure, it's dramatic to start the story off with how they overcame their affliction. But they overcome it and spend the majority of the time fighting evil, right?
Yes, but that is immaterial- if their workarounds are ever compromised or destroyed, they're in deep trouble.
Consider Dennett's Brain in a Vat...
http://instruct.west valley.edu/lafave/WhereAmI_online.html
With a literal flip of a switch, Dennett would be unable to to control his body.
As for Ben January, he sounds like a civil war era Bruce Wayne. He's got brains, probably can take care of himself. His setback creates drama for him, but when it comes to him actually being heroic, being a black man in New Orleans doesn't exactly intefere with playing piano or doing surgery.
1) He's really a non combatant type, not really a Bruce Wayne.
2) yes, being a black man in pre-CW NOLA does interfere with both:
As a pianist, he's going to get fewer gigs, and they will either be low paying and in dangerous areas, or well paid, but extremely rare since only a few people will be true fans.
As a surgeon, he will find it difficult to find (or afford-his piano gigs are what pay the bills) supplies, and again, he will be limited by whom he can treat. He will NOT be able to work in most hospitals as anything but an orderly, if that.
I REALLY haven't seen this. PCs with flaws tend to have ways to compensate for them.I think the flaws I cringe at (that [MENTION=4937]Celebrim[/MENTION] seems to agree are when players make a PC and are expected to create him in a crippled way that he can't be an effective adventurer.
<edit>
It might be a bit of a strawman to assume that folks are building un-adventurable adventurers using the D&D rules. But I've seen a few PCs trotted out as "look at my realistic PC, he's got flaws and stuff" and they're barely able to function socially, physically or mechanically.
With Stark and Elric, the flaws are present to create future situations where they are hampered by their ailment. But the majority of the time, they get to fly around and zap bad guys. Just like Superman gets nailed with kryptonite.
Again, see Dennett's BiaV. Just because a flaw has been compensated for does not mean the flaw has disappeared. Its continued existence figures into the person's daily mental calulus of what they can and cannot do.