Assume a base accuracy of 60%, and an attack dealing, say, 1d8+4 damage.
Attack with advantage:
- Chance of a hit: 84%
- Chance of adding crit damage: 9.75%
- Average damage: 7.14 (0.84 x 8.5) + ~0.44 (0.0975 x 4.5) = 7.58
Attack with elven accuracy and advantage:
- Chance of a hit: 93.6%
- Chance of adding crit damage: 14.2625%
- Average damage: ~7.96 (0.936 x 8.5) + ~0.64 (0.142625 x 4.5) = 8.6
So,
if you can reliably get advantage on your attack, EA gives you about a
13.5% damage boost. Not bad, not spectacular. If you need to even up your attack stat, and you're only interested in Moar Damage rather than spells or combat tricks, EA will do you fine. But wait; what if you also have Sharpshooter and you're using the -5/+10?
Attack with advantage and SS:
- Chance of a hit: 57.75%
- Chance of adding crit damage: 9.75%
- Average damage: ~10.68 (0.5775 x 18.5) + ~0.44 (0.0975 x 4.5) = 11.12
Attack with elven accuracy and advantage and SS:
- Chance of a hit: 72.5375%
- Chance of adding crit damage: 14.2625%
- Average damage: ~13.42 (0.725375 x 18.5) + ~0.64 (0.142625 x 4.5) = 14.06
Now the benefit is much more pronounced, a solid
26%. And this is for a feat that comes with a +1 stat boost, so you don't generally have to choose between leveling your attack stat and EA; you can have your cake and eat it too. As for whether you can get advantage in the first place... if you're using a Sharpshooter build, you're already grabbing advantage any way you can get it. You aren't going to be investing any
more resources to get advantage for EA.
(I might add that when I started writing this post, I thought I was going to be demonstrating that EA isn't very good. Turns out... in the right build, it really does live up to the hype.)